search

martykan / forecastie

A simple, opensource weather app for Android.
Other
871 stars 338 forks source link

Wrong icons for sunny day & few clouds in the notification #676

Open Yuubi-san opened 2 years ago

Yuubi-san commented 2 years ago

In the notification, the night versions of 'clear' and 'few clouds' icons are always displayed in place of the day versions, regardless of time of day. Both 'Simple' and 'Default' notifications are affected, while the icon in the main app UI is correct.

This may have something to do with there now being two different isDayTime functions, two different classes for data representation -- Weather and ImmutableWeather, two OWM json parsers, etc... 🤷

The new icon number to icon string conversion doesn't seem suspect, and the strings for day and night are different in the resources. I couldn't debug this further just by code gazing, but seems an easy fix when one is equipped with debugger or sprinkles some holy printfs on the problem.

ghost commented 1 year ago

I have the same issue. Here are some screenshoots:

1 2