martykan / forecastie

A simple, opensource weather app for Android.
Other
867 stars 335 forks source link

Rain measurement units fail to convert from mm to in #692

Open pigmonkey opened 1 year ago

pigmonkey commented 1 year ago

I have my length units set to inches. I noticed this morning that the rain amounts reported by Forecastie were impossibly high: 3.16 inches for the current conditions, 13.69 inches forecast for 2 hours later.

image

Upon switching the length unit back to the default millimeters, I saw almost identical numbers but with the unit label switched (which resulted in much more realistic measurements): 3.2 mm for the current conditions, 13.7 mm forecast for 2 hours later.

image

It seems that Forecastie is not actually converting millimeters to inches when the length unit setting is changed (but perhaps there is different rounding behaviour being applied to account for the slight change in the numbers). It only swaps the unit label.

The rain graph is not affected by this. When inches are selected, the y-axis was labeled 0 at the bottom and 1 at the top. The first bar was about halfway up the axis, which makes sense for a forecast of ~13mm aka ~0.5in.