martykan / webTube

Android wrapper for the YouTube website with a couple little tweaks.
GNU General Public License v3.0
96 stars 40 forks source link

Incorrect video size in fullscreen mode #123

Open mvglasow opened 3 years ago

mvglasow commented 3 years ago

To reproduce:

  1. Play a video.
  2. Tap the fullscreen icon (bottom-right corner of video).
  3. Observe the video size.
  4. Rotate the device by 90°.
  5. Repeat the last two steps as often as needed.

Expected result:

After tapping the fullscreen icon, the video is always resized to fill the screen (with padding either in the X or Y dimension, but not both).

Actual result:

After tapping the fullscreen icon, the top and bottom bars disappear, but the video does not occupy the full screen area – there is still padding in both dimensions (X and Y).

Rotating sometimes results in completely incorrect dimensions: the video still does not occupy the full screen, but parts are clipped. This behavior is sporadic, though.

After some rotations, the video is finally resized to fit the whole screen, with padding only in one dimension.

Versions:

1.2 (from F-Droid), on LineageOS 18.1 (Android 11).

Further comments:

It seems the code which determines the video size is prone to some race conditions or other sporadic bugs.