search

martymarron / xk6-output-prometheus-pushgateway

This is a k6 extension for publishing test-run metrics to Prometheus via Pushgateway.
Apache License 2.0
10 stars 5 forks source link

chore: k6 v0.47.0 #8

Closed llaszkie closed 10 months ago

llaszkie commented 10 months ago

Change k6 dependency to v0.47.0

martymarron commented 10 months ago

@llaszkie Thank you for your contribution! I'm having a look and running tests on my end. And I find the conflicts here. https://github.com/martymarron/xk6-output-prometheus-pushgateway/blob/main/pkg/pushgateway/collector_resolver/resolver_test.go#L236-L243

It seems the test implementation conflicts w/ below https://github.com/grafana/k6/blob/v0.47.0/metrics/sink.go#L96

Allow me to have more time to understand in detail. Thank you for your waiting and understanding 😊

llaszkie commented 10 months ago

@martymarron Right! I've tried to fix those too - but please take your time :-)

martymarron commented 10 months ago

@llaszkie Thank you for waiting. Merged your PR and released v0.2.4 including this change 🎉 https://pkg.go.dev/github.com/martymarron/xk6-output-prometheus-pushgateway@v0.2.4

Thank you again for your great contribution 👍