martyn-smith / Eastmann-Adversarial

Implementations of the Tennessee Eastmann process suitable for Adversarial Reinforcement Learning
0 stars 0 forks source link

Refine timesteps #20

Open martyn-smith opened 1 year ago

martyn-smith commented 1 year ago

Currently, time is being held at two places - in main loop (as integer), and in environment loop (as floating-point), with DELTA_t set in constants.

This appears ugly and violation of SSoT, although it may in fact be close to optimal due to the different needs (simulation step vs env step).

Consider this - it might just be a matter of better documentation.