Provide types for models

martynassateika / CodeIgniter-phpstorm-plugin

PhpStorm plugin for CodeIgniter development

Apache License 2.0

20 stars 10 forks source link

Provide types for models #15

Closed martynassateika closed 3 years ago

martynassateika commented 5 years ago

Version 0.4.0 introduced initial support for CodeIgniter 3's Models with a reference contributor and completion provider for model file names in $this->load->model (https://github.com/martynassateika/CodeIgniter-phpstorm-plugin/issues/6).

However even with this in place, loading model Foo using $this->load->model('foo') does not help PhpStorm.

Set up an extension of PhpTypeProvider2 that looks for $this->XXX field references.
Check if XXX is a model.
If so, set the type of the field reference to XXX_model.

martynassateika commented 5 years ago

Note that this won't work if people use the two-parameter $this->load->model version: https://www.codeigniter.com/user_guide/general/models.html#loading-a-model.

GerB commented 5 years ago

Hello,

Thank you for this plugin. It's a good start for me using PhpStorm instead of Netbeans, stuff like this is a huge time saver. If you can get around providing full library and model support (including references), that would really be great. If I can be some kind of help with that (no Java expert, sorry), just let me know.

Thanks again.

martynassateika commented 5 years ago

Hey GerB, thanks a lot for the kind words. Happy to hear the plugin is useful.

I have started work on model support some time ago, but then life got in the way. I will revisit the codebase this weekend.

By the way, I have also recently set up a personal website which at the moment acts as a blog, but will also house information about my IntelliJ IDEA / PhpStorm projects. Currently the only way to figure out what the plugin does is to look at the changelog. The site will expand more on each feature, kind of like a "What's New" page JetBrains put up whenever PhpStorm gets updated.