Currently, node-irc sends PASS before CAP REQ, causing Freenode to think the client isn't doing SASL auth. This PR omits sending PASS if options.sasl is true. Instead, the client sends CAP REQ, which the server should respond, CAP ACK, which is then handled correctly by node-irc.
jirwin
commented
8 years ago
Currently, node-irc sends PASS before CAP REQ, causing Freenode to think the client isn't doing SASL auth. This PR omits sending PASS if
options.saslistrue. Instead, the client sendsCAP REQ, which the server should respond,CAP ACK, which is then handled correctly by node-irc.I'm pretty sure this bug was introduced in https://github.com/martynsmith/node-irc/commit/c6d42625