Make SASL work for more networks.

martynsmith / node-irc

NodeJS IRC client library

GNU General Public License v3.0

1.32k stars 425 forks source link

Make SASL work for more networks. #445

Open creesch opened 8 years ago

creesch commented 8 years ago

snoonet.org doesn't return * as the first argument (unless that is intended as a wildcard, meaning the switch statement always has been broken for this case) and will not return 'sasl ' as was assumed but return 'sasl'.

creesch commented 8 years ago

@jirwin, I noticed you are most active here. What needs to be done to get this pull request merged?

jirwin commented 8 years ago

@creesch I'm working on building a better test harness for testing changes against a collection of real servers. In the mean time I'll do some manual testing and try to get this merged.

jmcparland commented 2 years ago

Wow ~ I just discovered this problem today and submitted a patch / pull request a few hours ago ~ five years later X-)