Open filler opened 7 years ago
I'm not really sure that this project is being updated any more – I forked it a while back (irc-upd on npm) and recently fixed up the SASL handling to be more compliant with the IRCv3 spec (including a change similar to this one – it requires only that sasl
be one of the arguments in the ACK response, and does not attempt to match the ident – and it now also emits an error if it gets a NAK response to the request). You might consider looking at that version of the library instead.
Some IRC daemons such as InspIRCd return an random string after a client's CAP REQ request. This would fail to match and block SASL AUTHENTICATEs. Also the space after
sasl
would also block the above AUTHENTICATEs.This change:
Example InspIRCd output: