search

martynsmith / node-irc

NodeJS IRC client library
GNU General Public License v3.0
1.32k stars 425 forks source link

can you not name your patches like this kthnx #532

Open Announcement opened 6 years ago

Announcement commented 6 years ago

os I saw you're using node-irc and was like oh cool, i'll take your fork it looks like it has a ton of patches then I saw these:

@davericher

  • Pull in patches
  • fixes
  • fixes
  • fixes
  • fixes
  • fixes
  • ..
  • fixes
  • FIX
  • fixes
  • fixes
  • fixes
  • werd
  • werd
  • werd
  • werd
  • werd
  • fixed multiple conneciton issues [goodish]
  • fix
  • Added Freenode Secure whois [goodish]
  • Kick Part fix [okayish]
  • fix
  • fix

literally can you not, please. atleast in the future.

tritium21 commented 6 years ago

https://github.com/martynsmith/node-irc/commits/master

I dont see commits with the names you describe. I also don't see pull requests named the way you describe. And I dont see any patch files in the repo anywhere.

https://github.com/martynsmith/node-irc/graphs/contributors

And I don't see the user you mention anywhere in the contributors list.

So.... what are you on about?

davericher commented 6 years ago

Feel free not to use it :D

acerspyro commented 5 years ago

You're given the opportunity to make use of an awesome project for free and you choose to instead nitpick like they owe you anything.

Real classy.

yardenac commented 5 years ago

I'd call it constructive criticism if there really were a bunch of poorly named commits like that, but ... there... aren't? o.0

davericher commented 5 years ago

He is upset I did not spend the time putting work in commit notes for a fork I did not really intend to share, because logic. I took a look at his github profile, 0 contributions, I bet there are an infinite amount of ungrateful remarks how ever.

davericher commented 5 years ago

For a teaching moment: If you are upset my fork is not clear, feel free to read the commits and add some notes to them, that way you are actually contributing to open source, and your input has value.