search

martynwheeler / u-lora

raspi-lora for micropython
GNU General Public License v3.0
74 stars 13 forks source link

power settings #1

Open ctorney opened 3 years ago

ctorney commented 3 years ago

Hi Thanks for creating this. I've been modifying the code to work with circuitpython but was getting some strange results with high power settings. I think this line is the issue: https://github.com/martynwheeler/u-lora/blob/3212535b6adadd2548d6d19f69407b819b6cfda2/ulora.py#L168 Should this be a greater than instead of a less than? This is code is different to the radiohead library (but I noticed the same as the raspi-lora code). I changed to match the original radiohead code and was able to use at high power. Cheers

martynwheeler commented 3 years ago

I will take a look when I get back home.

On Mon, 16 Aug 2021, 10:44 ctorney, @.***> wrote:

Hi Thanks for creating this. I've been modifying the code to work with circuitpython but was getting some strange results with high power settings. I think this line is the issue:

https://github.com/martynwheeler/u-lora/blob/3212535b6adadd2548d6d19f69407b819b6cfda2/ulora.py#L168 Should this be a greater than instead of a less than? This is code is different to the radiohead library (but I noticed the same as the raspi-lora code). I changed to match the original radiohead code and was able to use at high power. Cheers

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/martynwheeler/u-lora/issues/1, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABGVUFP5K5SWD7YFTCVB2U3T5DMWTANCNFSM5CHMDGPQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email .