search

martyr-deepin / deepin-screenshot

Deprecated (migrated into deepin-screen-recorder after v20), consider create and maintain your own fork if you love it.
https://www.deepin.org/original/deepin-screenshot/
GNU General Public License v3.0
347 stars 102 forks source link

Exit when doesn't specify picture name. #2

Open ruibinx opened 7 years ago

ruibinx commented 7 years ago

Deepin-screenshot will silently exit when not specifying captured picture names.

e.g., deepin-screenshot --save-path ~/Pictures/screenshots/ will exit with return code 1. It should instead save the picture in that directory.

Code at https://github.com/linuxdeepin/deepin-screenshot/blob/master/src/app_controller.py#L99-L101 should be related to the problem. I think simply removing these lines will fix this.

Thank you very much.

SalahAdDin commented 7 years ago

You can specific if you change the route of your picture before to take it, but only if you launch it from the software, not from the key shortcut; after do this now henceforth all time you have to choose his name and his folder.

Will be great add options for this software and for screen recorder.

ruibinx commented 7 years ago

@SalahAdDin I don't quite understand the difference between "from the software" and "from the key shortcut". It seems same to me. Still, looking at the code, I think this is a bug by accident.

Sadly, I don't think people from deepin will check issues on github after several month's wait. So it's never going to be fixed maybe.

ruibinx commented 7 years ago

@SalahAdDin btw, if you are interested, I use command like deepin-screenshot --save-path ~/Pictures/screenshots/$(date).png to bypass it.

SalahAdDin commented 7 years ago

I mean, front print screen key and from the software icon in the launcher.