martyr-deepin / deepin-terminal-gtk

DDE terminal emulator application
GNU General Public License v3.0
263 stars 57 forks source link

[Feature Request]Can you add feature: open as url by browser? #101

Closed iceqing closed 5 years ago

iceqing commented 5 years ago

Can you add the feature: open as url by browser?I using Deepin, but I Can't Ctrl+Left Mouse Button to Open URL.

Ref: Can't Ctrl+Left Mouse Button to Open URL

BLumia commented 5 years ago

This issue is now already fixed ( #100 ), you can clone this repo and build it by yourself if you like, or wait for the next tag version release so upstream will able to update the package ;)

If you would like to build deepin-terminal manually, do:

$ sudo apt build-dep deepin-terminal # install the build dept first
$ git clone https://github.com/linuxdeepin/deepin-terminal.git # please make sure git is installed
$ cd deepin-terminal
$ mkdir build && cd build
$ cmake -DCMAKE_INSTALL_PREFIX=/usr -DUSE_VENDOR_LIB=OFF ../
$ make # build it, after build, you'll get `deepin-terminal` in your current working dir.
$ sudo make install # will install it to /usr/bin/deepin-terminal so next time you'll use the one you built.
iceqing commented 5 years ago

It works, thank you very much.

git clone https://github.com/linuxdeepin/deepin-terminal.git
cd deepin-terminal
mkdir build; cd build; cmake ..; make; ./deepin-terminal
iceqing commented 5 years ago

@BLumia The master branch not working again, Could you help to find out why?

BLumia commented 5 years ago

The master branch not working again, Could you help to find out why?

It works on my side, anyway to reproduce? Which distro are you using now? If you are using Deepin or Archlinux, did the most up-to-date version (tag 3.2) works?

iceqing commented 5 years ago

@BLumia I'm using the laster version 3.2. It is strange that it works in firefox when firefox is default application, it does not work when Chromium is default application.

image

BLumia commented 5 years ago

Could you check if xdg-open https://github.com works when you set Chromium / Google Chrome as your default browser?

iceqing commented 5 years ago

Yes, xdg-open https://github.com works when I set Chromium / Google Chrome as my default browser.

iceqing commented 5 years ago
[1:1:0114/195529.812106:FATAL:zygote_main_linux.cc(283)] Check failed: sandbox::ThreadHelpers::IsSingleThreaded(). 
#0 0x55a41bebadfe <unknown>
#1 0x55a41bed988c <unknown>
#2 0x55a41ac7cf6b <unknown>
#3 0x55a41bbc42a6 <unknown>
#4 0x55a41bbc459e <unknown>
#5 0x55a41bbccf56 <unknown>
#6 0x55a41bbc3b59 <unknown>
#7 0x55a41a538e90 ChromeMain
#8 0x7fd76ebd0a87 __libc_start_main
#9 0x55a41a538cea _start

Received signal 6
#0 0x55a41bebadfe <unknown>
#1 0x55a41a52229b <unknown>
#2 0x55a41bebb6ee <unknown>
#3 0x7fd77a98ef50 <unknown>
#4 0x7fd76ebe3e7b gsignal
#5 0x7fd76ebe5231 abort
#6 0x55a41beb55f9 <unknown>
#7 0x55a41bed97f6 <unknown>
#8 0x55a41ac7cf6b <unknown>
#9 0x55a41bbc42a6 <unknown>
#10 0x55a41bbc459e <unknown>
#11 0x55a41bbccf56 <unknown>
#12 0x55a41bbc3b59 <unknown>
#13 0x55a41a538e90 ChromeMain
#14 0x7fd76ebd0a87 __libc_start_main
#15 0x55a41a538cea _start
  r8: 0000000000000000  r9: 00007ffd71250e30 r10: 0000000000000008 r11: 0000000000000246
 r12: 00007ffd712512c0 r13: 00007ffd712512e0 r14: 0000000000000073 r15: 00007ffd712512d0
  di: 0000000000000002  si: 00007ffd71250e30  bp: 00007ffd71251080  bx: 0000000000000006
  dx: 0000000000000000  ax: 0000000000000000  cx: 00007fd76ebe3e7b  sp: 00007ffd71250e30
  ip: 00007fd76ebe3e7b efl: 0000000000000246 cgf: 002b000000000033 erf: 0000000000000000
 trp: 0000000000000000 msk: 0000000000000000 cr2: 0000000000000000
[end of stack trace]
Calling _exit(1). Core file will not be generated.
[11749:11749:0114/195529.815568:FATAL:zygote_host_impl_linux.cc(209)] Check failed: ReceiveFixedMessage(fds[0], kZygoteHelloMessage, sizeof(kZygoteHelloMessage), &real_pid). 
#0 0x5598e703edfe <unknown>
#1 0x5598e705d88c <unknown>
#2 0x5598e6164258 <unknown>
#3 0x5598e5e53b84 <unknown>
#4 0x5598e6169169 <unknown>
#5 0x5598e61b7131 <unknown>
#6 0x5598e5e4bb5c <unknown>
#7 0x5598e5e5680e <unknown>
#8 0x5598e5e4c6a2 <unknown>
#9 0x5598e6d4859e <unknown>
#10 0x5598e6d50f56 <unknown>
#11 0x5598e6d47b59 <unknown>
#12 0x5598e56bce90 ChromeMain
#13 0x7f8d5a13ba87 __libc_start_main
#14 0x5598e56bccea _start

Received signal 6
#0 0x5598e703edfe <unknown>
#1 0x5598e56a629b <unknown>
#2 0x5598e703f6ee <unknown>
#3 0x7f8d65ef9f50 <unknown>
#4 0x7f8d5a14ee7b gsignal
#5 0x7f8d5a150231 abort
#6 0x5598e70395f9 <unknown>
#7 0x5598e705d7f6 <unknown>
#8 0x5598e6164258 <unknown>
#9 0x5598e5e53b84 <unknown>
#10 0x5598e6169169 <unknown>
#11 0x5598e61b7131 <unknown>
#12 0x5598e5e4bb5c <unknown>
#13 0x5598e5e5680e <unknown>
#14 0x5598e5e4c6a2 <unknown>
#15 0x5598e6d4859e <unknown>
#16 0x5598e6d50f56 <unknown>
#17 0x5598e6d47b59 <unknown>
#18 0x5598e56bce90 ChromeMain
#19 0x7f8d5a13ba87 __libc_start_main
#20 0x5598e56bccea _start
  r8: 0000000000000000  r9: 00007fff34296c40 r10: 0000000000000008 r11: 0000000000000246
 r12: 00007fff342970d0 r13: 00007fff342970f0 r14: 00000000000000ae r15: 00007fff342970e0
  di: 0000000000000002  si: 00007fff34296c40  bp: 00007fff34296e90  bx: 0000000000000006
  dx: 0000000000000000  ax: 0000000000000000  cx: 00007f8d5a14ee7b  sp: 00007fff34296c40
  ip: 00007f8d5a14ee7b efl: 0000000000000246 cgf: 002b000000000033 erf: 0000000000000000
 trp: 0000000000000000 msk: 0000000000000000 cr2: 0000000000000000
[end of stack trace]
Calling _exit(1). Core file will not be generated.
iceqing commented 5 years ago

It works well when I change /usr/share/applications/google-chrome.desktop Exec toExec=/usr/bin/google-chrome-stable --no-sandbox %U

BLumia commented 5 years ago

😂 It's useless if we got a backtrace with full <unknown> content, maybe you should install the -dbgsym package first. btw, did you test if gio open https://github.com works when you set chrome as your default browser?

It works well when I change /usr/share/applications/google-chrome.desktop Exec toExec=/usr/bin/google-chrome-stable --no-sandbox %U

It works out of box on my side without modifying any content, what's the original value in your google-chrome.desktop with Exec key?

I think it's probably not an issue of the deepin-terminal itself.