search

martyr-deepin / deepin-terminal-gtk

DDE terminal emulator application
GNU General Public License v3.0
263 stars 57 forks source link

vala: fix build with latest vte3 #221

Closed sgn closed 4 years ago

sgn commented 4 years ago

In Vala (as of version 0.46.3), string::to_utf8() returns "char[]", but Terminal::feed_child() expects "unowned uint8[]" instead.

VTE 0.60.0 has changed signature

I don't have much experience with Vala. Here's a simple fix for this problem.

worldofpeace commented 4 years ago

You need to do conditional compilation to have this build with older versions. This commit in elementary-terminal would be helpful https://github.com/elementary/terminal/commit/7dd6f93c9cd9e3d44407649a99ab0c3c17670a1a. This LGTM.

sgn commented 4 years ago

I separated into 2 patches series. I tried to build with vte3 0.59.{0,91,92} and 0.60.{0,1}