search

martyr-deepin / deepin-terminal-gtk

DDE terminal emulator application
GNU General Public License v3.0
264 stars 57 forks source link

Search improvements #46

Closed avently closed 6 years ago

avently commented 6 years ago

Ok, what's wrong with the current code.

type command in your version of terminal: 

cat /proc/cpuinfo

Then select any word and press search hotkey Ctrl+Shift+F and press next/previous arrow icon or Enter key on keyboard. Search not working, right? That's the problem.

Problem number 2. While you see the command output from the previous cat command open up search box with hotkey again and type "proce". Then type another key "proces". Then another "process". Notice that every time you are entering a character you search position in a view changes even when the search position is completely right. I mean when you pressed "proce" terminal found word "processor" for you. Then you pressed another key and the terminal jumped from that word to another word "processor" that located in the terminal too. It is a real pain when I have a loooong terminal output in a workspace.

manateelazycat commented 6 years ago

I see the problem.

Patch is merged, great work!