search

martyr-deepin / deepin-wm

Deprecated, consider create and maintain your own fork if you love it.
GNU General Public License v3.0
72 stars 30 forks source link

Blocks workspace switches while multitasking view toggle animation is active #4

Closed Manuel-Kehl closed 8 years ago

Manuel-Kehl commented 8 years ago

Fixes #3.

I have solved the problem described in #3 by simply blocking workspace switch commands as long as the multitasking view's toggle animation is running. As explained in the git comments, delaying the workspace switch instead of blocking it.

I personally prefer blocking, because I feel like a delay might feel "sluggish" to the user, but we could experiment. Maybe it's hardly recognizable.

sonald commented 8 years ago

@fasheng Thanks for the patch, the fix's fine. Although I prefer quick responsiveness but blocking is absolutely ok at this situation.

fasheng commented 8 years ago

Thanks very much. But looks the github2gerrit plugin still not works. I will download the PR and push to gerrit manually(we host repos in github as mirrors for https://cr.deepin.io), and close here then.