search

martyzz1 / heroku3.py

This is the updated Python wrapper for the Heroku API V3. https://devcenter.heroku.com/articles/platform-api-reference The Heroku REST API allows Heroku users to manage their accounts, applications, addons, and other aspects related to Heroku. It allows you to easily utilize the Heroku platform from your applications.
Other
118 stars 73 forks source link

Added validation for app name #108

Closed elfkuzco closed 3 years ago

elfkuzco commented 3 years ago

Added validation for the application name to conform to Heroku application naming standards according to the docs. Helps prevent making request to the API if it doesn't conform to the standard as it will generate the same error.

codecov-commenter commented 3 years ago

Codecov Report

Merging #108 (eb52ae1) into master (66e3f3a) will increase coverage by 0.03%. The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #108      +/-   ##
==========================================
+ Coverage   50.25%   50.29%   +0.03%     
==========================================
  Files          29       30       +1     
  Lines        1349     1362      +13     
  Branches      119      121       +2     
==========================================
+ Hits          678      685       +7     
- Misses        662      668       +6     
  Partials        9        9
Impacted Files Coverage Δ
heroku3/api.py 40.51% <40.00%> (-0.07%) :arrow_down:
heroku3/models/app.py 32.69% <40.00%> (+0.22%) :arrow_up:
heroku3/helpers.py 94.33% <50.00%> (-3.62%) :arrow_down:
heroku3/exceptions.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 66e3f3a...eb52ae1. Read the comment docs.

martyzz1 commented 3 years ago

Great stuff, thanks for this...