search

martyzz1 / heroku3.py

This is the updated Python wrapper for the Heroku API V3. https://devcenter.heroku.com/articles/platform-api-reference The Heroku REST API allows Heroku users to manage their accounts, applications, addons, and other aspects related to Heroku. It allows you to easily utilize the Heroku platform from your applications.
Other
118 stars 73 forks source link

Is it possible to create SSL endpoints with this? #110

Closed mrmikardo closed 3 years ago

mrmikardo commented 3 years ago

This functionality is exposed by the Platform API: https://devcenter.heroku.com/articles/platform-api-reference#ssl-endpoint-create

But I couldn't figure out how to achieve that using heroku3.

mrmikardo commented 3 years ago

I am working on a PR for this 👍

martyzz1 commented 3 years ago

thats Great. Thank you

mrmikardo commented 3 years ago

Have tested this by attempting to make a request through the API, which returns an error: "The SSL Endpoint add-on needs to be installed on this app to manage endpoints."

But the SSL Endpoint add-on is now deprecated: https://devcenter.heroku.com/changelog-items/2145

Might be possible to implement similar functionality with the SNI Endpoints API: https://devcenter.heroku.com/articles/platform-api-reference#sni-endpoint

mrmikardo commented 3 years ago

@martyzz1 PR here: https://github.com/martyzz1/heroku3.py/pull/111

Please let me know what you think!

mrmikardo commented 3 years ago

Hey @martyzz1 anything I can do to help speed this up?

mrmikardo commented 3 years ago

@martyzz1 thanks for merging the PR! Can consider this closed 😄

martyzz1 commented 3 years ago

no worries. Thanks for the contribution.

On Mon, 11 Oct 2021 at 15:39, Jack Westmore @.***> wrote:

@martyzz1 https://github.com/martyzz1 thanks for merging the PR! Can consider this closed 😄

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/martyzz1/heroku3.py/issues/110#issuecomment-940091797, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAMG6S6G5MCH6Z5EUCPHEE3UGLZKZANCNFSM5E432SRA .