search

martyzz1 / heroku3.py

This is the updated Python wrapper for the Heroku API V3. https://devcenter.heroku.com/articles/platform-api-reference The Heroku REST API allows Heroku users to manage their accounts, applications, addons, and other aspects related to Heroku. It allows you to easily utilize the Heroku platform from your applications.
Other
118 stars 73 forks source link

Domain Create endpoint API has changed #115

Closed mrmikardo closed 2 years ago

mrmikardo commented 2 years ago

The Domain Create endpoint now requires an sni_endpoint parmeter: https://devcenter.heroku.com/articles/platform-api-reference#domain-create

This means that calls to app.add_domain(...) are now raising 422 errors.

The solution is to update the API to add the sni_endpoint parameter - also need to figure out exactly what SNI endpoint needs to be passed, and if/how that plays with Heroku's Automated Certificate Management (ACM).

I'm happy to look into this and make a PR for it over the next week or so.

martyzz1 commented 2 years ago

This change was released last weekend...

https://github.com/martyzz1/heroku3.py#domains

Make sure you have upgraded to the latest version

mrmikardo commented 2 years ago

@martyzz1 many thanks for pointing this out, my bad for not spotting that - I will upgrade our copy of the library now.