search

martyzz1 / heroku3.py

This is the updated Python wrapper for the Heroku API V3. https://devcenter.heroku.com/articles/platform-api-reference The Heroku REST API allows Heroku users to manage their accounts, applications, addons, and other aspects related to Heroku. It allows you to easily utilize the Heroku platform from your applications.
Other
118 stars 73 forks source link

BaseResource._keys() method does not return dict attributes. #52

Open cans opened 6 years ago

cans commented 6 years ago

The method BaseResource._key() does not include the attributes decalred in BaseResource._dicts.

Is that intentional or not ? Chaiging this would impact the following methods:

That latter method seem to be dead code: never called anywhere as far as grep can tell, but then it is also part of the class public AP, so removing it may not be the best idea. But if we agree the omission of dict attributes is a bug, then it should be fixed.

Any clue ? Regards, Nicolas.

cans commented 6 years ago

By the way should that ._keys() method be a @classmethod makes to make introspection at the class level as much as at the instance level no ? Changing that would not break the API).