search

martyzz1 / heroku3.py

This is the updated Python wrapper for the Heroku API V3. https://devcenter.heroku.com/articles/platform-api-reference The Heroku REST API allows Heroku users to manage their accounts, applications, addons, and other aspects related to Heroku. It allows you to easily utilize the Heroku platform from your applications.
Other
118 stars 73 forks source link

Chore/add unit tests #54

Closed cans closed 6 years ago

cans commented 6 years ago

This pull request introduces the first bits of comprehensive unit testing for this package.

First commit simply adds requirement files on testing and dev tools. It also lays part of the filesystem hierarchy to store tests.

Second commits add tests for the heroku3.helpers module. And to that end also fixes issue martyzz1/heroku3.py#52

Third commit adds tests for the herku3.models.configvars module. It is a bit more involved than the first two commits as it also includes some refactoring on that module to make it easier to test, render ConfigVars instances less prone to internal state hijacking and some other issues raised in issue martyzz1/heroku3.py#53. As such it requires more scrutiny.

While I think i represent substantial enough changes for justifying a merge in the master branch, I would obviously not advise including this in any release until broader test coverage is available.

martyzz1 commented 6 years ago

I'll need to go through this in more detail, But words cannot express how grateful I am to you for this... it has been on my todo for an embaressingly long time :)

Alir3z4 commented 6 years ago

This is great. Any idea when this would be merged @martyzz1 ?