search

martyzz1 / heroku3.py

This is the updated Python wrapper for the Heroku API V3. https://devcenter.heroku.com/articles/platform-api-reference The Heroku REST API allows Heroku users to manage their accounts, applications, addons, and other aspects related to Heroku. It allows you to easily utilize the Heroku platform from your applications.
Other
118 stars 73 forks source link

simplejson dependency is pinned to version 3.3.1 #84

Closed MDziwny closed 4 years ago

MDziwny commented 4 years ago

I'm using the version 3.4.0 of heroku3 and 1 of the requirement is simplejson which is pinned to version simplejson==3.3.1.

It's problematic because it conflicts with other packages using a higher version number, in my case simplejson>=3.16.0.

Would it be possible to use simplejson>=3.3.1,<4 ?

martyzz1 commented 4 years ago

Could you submit a pr? For it...

On Mon, 21 Oct 2019, 17:55 Antoine Fontaine, notifications@github.com wrote:

I'm using the version 3.4.0 of heroku3 and 1 of the requirement is simplejson which is pinned to version simplejson==3.3.1.

It's problematic because it conflicts with other packages using a higher version number, in my case simplejson>=3.16.0.

Would it be possible to use simplejson>=3.3.1,<4 ?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/martyzz1/heroku3.py/issues/84?email_source=notifications&email_token=AAMG6SZWJPC4QNY2I42WBMDQPXNJZA5CNFSM4JDA76M2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HTHZIDQ, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAMG6S4TP6WF2DPL3WSHQ5TQPXNJZANCNFSM4JDA76MQ .

MDziwny commented 4 years ago

I wanted to do it but I've noticed that this package is not anymore declared in the requirements declared in setup.py:

https://github.com/martyzz1/heroku3.py/blob/601a1f5fcae64a62ae6e17eb9befb899f8aba95b/setup.py#L17L20

martyzz1 commented 4 years ago

ah, apologies... This was already done

https://github.com/martyzz1/heroku3.py/pull/73

Are you using the latest version? e.g. install from Master branch?

MDziwny commented 4 years ago

No, I'm installing it through pypi https://pypi.org/project/heroku3/

pip install heroku3==heroku3==3.4.0
martyzz1 commented 4 years ago

you could use

   pip install git+https://github.com/martyzz1/heroku3.py
MDziwny commented 4 years ago

Yes, it's ok in a dev environment but we're using this tool in a lot of scripts, which are sometime included in a docker image, and it's not nice to depend on a git repository (caching is not working fine, more prone to changes, ...)

martyzz1 commented 4 years ago

I completely understand, and at some point when I have time to test out all the various PR's I merged recently, I will make a new release to pypi... In the meantime, I'd suggest you use the github link directly, but pin it to a commit that you are happy with. I run many production projects, and not all the libraries we use are on pypi, and pinning to a commit in a branch on github works perfectly fine.

    pip install git+https://github.com/martyzz1/heroku3.py@bd3e24a

https://stackoverflow.com/questions/13685920/install-specific-git-commit-with-pip

martyzz1 commented 4 years ago

going to close this for now...