search

maru / libmicrohttpd-http2

HTTP/2 support for libmicrohttpd
https://http2.s106.net/
Other
22 stars 6 forks source link

Update doc/libmicrohttpd.texi #59

Open maru opened 5 years ago

maru commented 5 years ago

documentation (texi) was not updated to document the new
options from the new header or to the build system.

maru commented 5 years ago

It would also be good to have an additional section in the tutorial on use of HTTP/2.

SharmaShikha-84 commented 5 years ago

Hello,

I was trying out the implementation and have a question regarding the same. When we try to initiate a HTTP2 connection with prior knowledge, It creates a new stream and passes the (MHD_Connection)connection object to the application. But the connection object is missing the client source_addr information. MHD_get_connection_info(MHD_CONNECTION_INFO_CLIENT_ADDRESS) returns NULL.

I noticed that h2_stream_create creates a new MHD_Connection for that stream but did I miss something because of which that information is not included in the new object? It only has a subset of information from the original connection object.

Thanks, Shikha

On Wed, Jun 19, 2019 at 11:09 AM Maru Berezin notifications@github.com wrote:

It would also be good to have an additional section in the tutorial on use of HTTP/2.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/maru/libmicrohttpd-http2/issues/59?email_source=notifications&email_token=AE2EYJE6UT2PJGZQONN37NDP3HZWDA5CNFSM4HZHPJH2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYBHARQ#issuecomment-503476294, or mute the thread https://github.com/notifications/unsubscribe-auth/AE2EYJAJLQHU6CFKHKZ4DSDP3HZWDANCNFSM4HZHPJHQ .

maru commented 5 years ago

Hi Shikha, I will open another issue for the bug you're reporting (this issue is about the documentation).