search

marubinotto / Piggydb

Piggydb is a Web notebook application that provides you with a platform to build your knowledge personally or collaboratively.
http://piggydb.net/
Apache License 2.0
149 stars 35 forks source link

Mathjax load from cdn makes Piggydb unusable without internet connetction #9

Closed corvus-ch closed 8 years ago

corvus-ch commented 10 years ago

The Mathjax JS library is loaded via CDN. This makes Piggydb (6.18-supporters) unusable without a connection to the internet.

I suggest to either include Mathjax to the package or check if it is loaded before using it.

GET http://cdn.mathjax.org/mathjax/latest/MathJax.js?config=TeX-AMS_HTML net::ERR_INTERNET_DISCONNECTED fragment.htm:60
Uncaught ReferenceError: MathJax is not defined piggydb.widget.Fragment.js?6.18-supporters:41
Uncaught ReferenceError: MathJax is not defined piggydb.widget.Fragment.js?6.18-supporters:38
marubinotto commented 10 years ago

I think Mathjax is too heavy to be included in the package, so it would be better to provide an option to disable it.

corvus-ch commented 10 years ago

I do not see that argument. Sure Mathjax would add over 32MB to the package bot not doing so would prevent using its functionality when offline.

As I see it, the only valid reason to not add it, are legal ones (e.g. license miss match).

marubinotto commented 8 years ago

Fixed by including MathJax in the package. Will be released in v7.0