marucjmar / ember-cli-tinymce

The ember wysiwyg editor powered by tinyMCE
http://marucjmar.github.io/ember-cli-tinymce
MIT License
40 stars 19 forks source link

Feature Request: load tinymce from assets.. #24

Open bluscreen opened 6 years ago

bluscreen commented 6 years ago

Hi marucjmar

I would very much prefer to load the tinymce locally instead of cdn.tinymce.com Do you think you can integrate this feature?

Cheers Daniel

marucjmar commented 6 years ago

Hi @bluscreen

Good idea 👍
Tomorrow I'll take care of it

bluscreen commented 6 years ago

Hi marucjmar

any progress on this? otherwise I guess I'll have to manually install tinymce via node :face_with_head_bandage:

bluscreen commented 6 years ago

in case youre still interested, i got an approach running now using npm and ember browserify. its still quite brittle but it works..

marucjmar commented 6 years ago

I'm working on it. You can see my progress on branch load-from-assets. In dev environment work correctly, but not when build production app.

bluscreen commented 6 years ago

Hi thats probably due to minification and or fingerprinting. You can disable this in ember cli build config. Cheers Daniel

Marcin Lazar notifications@github.com schrieb am Mo., 26. März 2018, 09:32:

I'm working on it. You can see my progress on branch load-from-assets. In dev environment work correctly, but not when build production app.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/marucjmar/ember-cli-tinymce/issues/24#issuecomment-376072389, or mute the thread https://github.com/notifications/unsubscribe-auth/AFPtJZcmbnsSUxgmqtd_FOKj4hzXTkJVks5tiJmmgaJpZM4R_BF1 .

ziali088 commented 6 years ago

++ also waiting for this

ziali088 commented 6 years ago

Hi @marucjmar,

Could you roll this out? ember-cli-tinymce is always using tinymce version 4.4 for me and that has a bug with image attachments that's affecting me and is fixed in later versions (link to issue).

Thanks for the contribution!

marucjmar commented 6 years ago

@ziali088 can you show your environment.js config? this solution does not help?

  ENV = {
  ...
   tinyMCE: {
      load: true,
      version: 4.5
    }
}
ziali088 commented 6 years ago

Yes updating the config does fix it, but my concern was more of a now buggy version being the default :)