marudy / react-native-responsive-screen

Make React Native views responsive for all devices with the use of 2 simple methods
MIT License
1.56k stars 142 forks source link

Fixed #21 #23

Open ahmedkamalio opened 5 years ago

ahmedkamalio commented 5 years ago

As lschuft mentioned it's not a good approach to meth the component's props, instead the listenOrientationChange may return the original handler, store it somewhere and push it back to removeOrientationListener

ahmedkamalio commented 5 years ago

Hey, @marudy your comments have been resolved, but I can't sync this brunch with you updated master brunch I think I have to reopen new PR or just merge this one as is.