search

marudy / react-native-responsive-screen

Make React Native views responsive for all devices with the use of 2 simple methods
MIT License
1.55k stars 141 forks source link

Add flow type declarations #64

Closed sanjaypojo closed 4 years ago

sanjaypojo commented 4 years ago

Closes #32

sanjaypojo commented 4 years ago

@marudy here's the PR that I had mentioned! Let me know if you want any changes :)

marudy commented 4 years ago

@sanjaypojo thanks for the PR. Can you maybe add a quick note in README as well ? Also did you test your additions locally to see if they work as expected? If yes we can release it soon.

Thanks!

sanjaypojo commented 4 years ago

@marudy I've tested the additions locally and it works fine! With regards to usage, flow types should just automatically work. Where in the readme should we add it? Didn't find anything for TS, but they should probably go together

marudy commented 4 years ago

@sanjaypojo merged! I'd put it some description in README under The Package -> Updates. If we add that as well, it will be awesome 👍

marudy commented 4 years ago

@sanjaypojo released new version 1.4.0 that contains this . Thanks for the help 👍

sanjaypojo commented 4 years ago

Awesome, thanks for the update @marudy :)