marunjar / anewjkuapp

GNU General Public License v3.0
16 stars 4 forks source link

Format string in notifications not properly applied #155

Closed leicmi closed 3 years ago

leicmi commented 3 years ago

Hi, thank you for supporting this app, it's a pleasure to use it :)

There seems to be a minor issue with some notifications that include quantities in their text, for example: image

This is probably caused by not passing a parameter twice when calling getQuantityString as described here.

Here's one of the lines where the parameter is not passed twice:

https://github.com/marunjar/anewjkuapp/blob/460f85cff5b0c48b5ebb6486d65e8e4a36e31f92/app/src/main/java/org/voidsink/anewjkuapp/notification/NewExamNotification.java#L113

Unfortunately I do not have the infrastructure set up, otherwise I'd have tried to fix and test it myself.