maruohon / autoverse

A Minecraft mod about simple automation
GNU General Public License v3.0
6 stars 4 forks source link

Block detector not working as intended #9

Closed wormzjl closed 5 years ago

wormzjl commented 6 years ago

If it detects the correct item but the detection items buffer is empty, item in the others buffer will be sent out instead. I think in such cases it should not send out items to prevent issues?

maruohon commented 6 years ago

This might also be a bit subjective or application-specific which way it should work... So if your detection items have ran out, and the detector wouldn't send out the other item, then you could run into a wall if you are relying on the detector to control a frame machine. Not sure if I should change this or not... πŸ€”

wormzjl commented 6 years ago

That depends also on the application...What was the designed purpose anyway?

maruohon commented 6 years ago

The original use case was "sniffing for resources" in a custom generation world where there would have been some kind of resource patches all over the place on the surface.

But I guess it might make sense to not send the other items out, if there is actually a detection match, just those items had run out already.

wormzjl commented 5 years ago

Oh I see, I was thinking about that the resources are underground like vanilla :P

maruohon commented 5 years ago

Yeah for that it would need to be a cheaty x-ray sniffer :p

But I would imagine in an underground use case the whole thing is usually a frame quarry, so you basically just drive it through the terrain in straight lines and gather whatever is there.

wormzjl commented 5 years ago

Omnidirectional ore-eater worm yeah, but still one can tweak the ore gen to make it looks like a cloud or something.

Matti Ruohonen notifications@github.com 于 2018εΉ΄9月20ζ—₯周四 01:11ε†™ι“οΌš

Yeah for that it would need to be a cheaty x-ray sniffer :p

But I would imagine in an underground use case the whole thing is usually a frame quarry, so you basically just drive it through the terrain in straight lines and gather whatever is there.

β€” You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/maruohon/autoverse/issues/9#issuecomment-422862993, or mute the thread https://github.com/notifications/unsubscribe-auth/AC2b0eFIAZ2oYKdTCd0rPXkVlih5oekvks5ucmyWgaJpZM4WNL3u .