maruohon / enderutilities

A Minecraft mod that adds various (mostly "ender-themed") blocks and items
GNU Lesser General Public License v3.0
27 stars 15 forks source link

Nullifier Visuals #79

Open Thiana opened 6 years ago

Thiana commented 6 years ago

Could you make the visual of the Nullifier match more closely to regular block size? At the moment it's large enough to block a significant portion of the screen. In the image below, the standard size is on the left and the Nullifier on the right. Thank you.

2018-08-02_00 36 42

maruohon commented 6 years ago

Whaaat?! O_o This is how it has always been supposed to look like: 2018-08-02_15 55 45

So some kind of cross-mod issue, and with rendering nonetheless ... >_> Two of my worst arch enemies...

But now looking at it, I should still probably also change the first person model transform a bit, to lower it down, as it takes a lot more screen space than just holding a block in your hand.

Thiana commented 6 years ago

I'm not sure this actually counts as a bug since It looks like it's Foamfix by @asiekierka causing the issue. Specifically the optimization:

# Remove unnecessary data from a pointlessly cached ModelLoader instance. [default: true]
B:modelLoaderCleanup=false

Maybe asie can suggest a way to have foamfix ignore the Nullifier instance?

Versions: forge 14.23.4.2739 enderutilities-1.12.2-0.7.11.jar foamfix-0.9.9.1-1.12.2-anarchy.jar

With foamfix defaults:

2018-08-03_06 48 49

With B:modelLoaderCleanup disabled.

2018-08-03_06 49 50

Thiana commented 6 years ago

After using the Nullifier for a few weeks I agree that it's a touch too large. Could you consider shrinking it slightly and lowering it a bit in future versions? Thanks.

PS: Since it looks like asie doesnt follow mentions, would you like me to open an issue in the foamfix repo about B:modelLoaderCleanup or just close this issue?

maruohon commented 6 years ago

Yeah I'll try to adjust it for the next release. If you want to try to follow up on this on the Foamfix side, go ahead. I don't know if there is something I should be doing differently on my side, so I'd be glad to hear that too if it's the case.

asiekierka commented 6 years ago

I do! I actually looked at this issue, but couldn't find anything immediately wrong.