search

maruohon / itemscroller

A client-side Minecraft mod that adds various convenient ways of moving items within inventory GUIs, such as scrolling over stacks to move single items to or from it
GNU Lesser General Public License v3.0
150 stars 77 forks source link

fix reverse scroll direction #17

Closed LuminaSapphira closed 5 years ago

LuminaSapphira commented 5 years ago

This fixes the reverse scrolling direction configuration option for single items not affecting anything (the value was never read in the code). According to the commit history of this project, this line was changed but I can't figure out why, so I think it's a bug, so this fix just changes it back.

Full disclosure: I'm not 100% sure this fix doesn't break anything else, but it definitely fixes being unable to reverse scrolling direction for single items.

maruohon commented 5 years ago

Thanks.

It was most likely a copy-paste fail while I was taking the changes from the Liteloader branch... I didn't merge because I didn't want all the config related differences that branch has, so I mostly manually copy pasted blobs of code from the Liteloader version back to the Forge version and then adjusted the config variables back to what they are in the Forge version, and probably forgot to rename that config variable after copy pasting, or something like that.

comp500 commented 5 years ago

Could a build with this bug fix be uploaded to CurseForge?

vacla commented 5 years ago

it can be found on https://masa.dy.fi/tmp/minecraft/mods/client_mods/

comp500 commented 5 years ago

That seems to be only the LiteLoader version of Item Scroller. I should be able to compile it myself, but it is easier for other people if the fixed Forge version is put on CurseForge.