maruohon / itemscroller

A client-side Minecraft mod that adds various convenient ways of moving items within inventory GUIs, such as scrolling over stacks to move single items to or from it
GNU Lesser General Public License v3.0
147 stars 69 forks source link

[Suggestion] Option to disregard enchantments/durability when dropping or moving all matching items. #49

Open Jalco28 opened 3 years ago

Jalco28 commented 3 years ago

When dealing with the output of a skeleton spawner grinder I tried to use drop all of the bows using drop all matching but it only dropped one. I went into a creative world and found that items are "different" if they have different durability/enchantments.

It would be nice to have a way to deal with situations like this. I don't know anything about java coding, but something to the effect of checking the namespaced id of an item and using that to define whether or not an item is the "same".

maruohon commented 3 years ago

This is on the todo list. Currently most of the item checks are simply strict, they check that both the item is the same, and also that the entire NBT data is identical. There are situations where you would like to ignore the damage or other NBT data, but on the other hand in some cases you do want to match it.

So I'm unsure what the best way to handle this would be, one option is to just add a global option (or a few, for different actions) for whether or not to check anything beyond the same item. But going to the config menu all the time to flip that would probably be annoying, so I might instead just add different hotkey combinations for the action variants that either ignore or check the full NBT data, such as holding Shift to drop based on the item type alone, and holding Alt to drop only fully identical items. I might need to shuffle around the default hotkeys then a bit to try to keep things as consistent as possible, so that it's easier to remember how they work.