search

maruohon / itemscroller

A client-side Minecraft mod that adds various convenient ways of moving items within inventory GUIs, such as scrolling over stacks to move single items to or from it
GNU Lesser General Public License v3.0
147 stars 68 forks source link

[Mod compat] [Bug] clientCraftingFixOn1.12 prevents crafting inventory from being altered during crafting #69

Closed vlad2305m closed 2 years ago

vlad2305m commented 2 years ago

itemscroller-fabric-1.17.1-0.15.0-dev.20210707.005506 So I made a recipe that consumes the stack as soon as you check for it (or craft() it), always outputting ItemStack.EMPTY. I have no idea why, but your fix completely reverts the changes made by the recipe, which you can see from the flicker of the item while updating the recipe. (Ideally, the second check retuns no recipe found, and result stack is empty anyway, so there is no need to set it to air again as you do in onSlotChangedCraftingGrid(), but the issue can lie somewhere else) https://youtu.be/36_J0hjAOn0

maruohon commented 2 years ago

Can you check if this version fixes it or changes anything? https://www.curseforge.com/minecraft/mc-mods/item-scroller/files/3542814

It should now not set an empty stack to the slot in that code.

vlad2305m commented 2 years ago

Works flawlessly. Thank you!