maruohon / justenoughdimensions

A simple Minecraft mod to register custom dimensions to the game
GNU General Public License v3.0
12 stars 7 forks source link

Add sky color fix, ability to change sun and moon's size and color #34

Closed ferreusveritas closed 5 years ago

ferreusveritas commented 5 years ago

As I mentioned on curseforge I made the changes needed to correct the sky color. The skyblend property is a float that will interpolate between the "vanilla" JED sky color at 0 and the "true" sky color at 1. By default it's 0 so it's backwards compatible with existing settings. I also added the ability to change the sun and moon's color. As well as scale their sizes.

ferreusveritas commented 5 years ago

I just now noticed that the fog color suffers from the same problem. If you intend to merge this change then I can update that was well. If you're not interested in merging then I won't bother.

maruohon commented 5 years ago

I quickly looked through this PR and it looks good. I'll merge it when I get the chance to try it out myself as well. Hopefully within a couple of days or so. So yeah you can update it to work with fog as well.

Thanks! :+1: