search

maruohon / justenoughdimensions

A simple Minecraft mod to register custom dimensions to the game
GNU General Public License v3.0
12 stars 7 forks source link

Crash with Journey into the Light?(Incompatible?) #59

Open Terra-B-Welch opened 3 years ago

Terra-B-Welch commented 3 years ago

So I've had a custom dimension registered ID 690, and without the mod Journey into the Light enabled, it works fine.

However upon adding Journey into the Light to the pack, I am met with this crash upon creation of a new world(or loading an existing world)

https://pastebin.com/MYREi1pZ

I have double checked JitL's config and have made sure none of its dimensions use the ID 690, yet this crash occurs. Without JitL, the dimension works fine and as intended.

Possible incompatibility?

maruohon commented 3 years ago

That crash would indicate that either the dimension fails to get registered for some reason, or the DimensionType enum's values() method does not find it, which may happen if the method is called too many times before the dimension is registered (as enums are not supposed to be modifid in Java).

Try if adding the load_on_start option for that dimension helps (which basically registers it already during server/game start and not only when the world is loaded, or however that worked by default). (Example on line 621 here: https://pastebin.com/d3EZzDY3).

Terra-B-Welch commented 3 years ago

Tried adding load_on_start to DIM 690, it made no difference, the same crash occurs.

maruohon commented 3 years ago

Then try enabling the verbose/info logging option in the JED main config, and see if you see any warnings/errors from when JED tries to register the dimension. Could you also post/pastebin your dimension config?

Terra-B-Welch commented 3 years ago

Heres the config for dimensions. https://pastebin.com/Eygu4Y6Y I'll try looking in the logs for anything that might be a lead, I've enabled the info logging.

Terra-B-Welch commented 3 years ago

unless that config option posts a seperate log file somewhere, this was all I dug up from logs. https://pastebin.com/MN0V88Rw

maruohon commented 3 years ago

Yep that stack trace points to this issue, unfortunately: https://github.com/MinecraftForge/MinecraftForge/issues/3885

Try using WorldProviderSurfaceJED in dim 690, that way JED can use one of the pre-registered DimensionType values for that dimension. Also unless you absolutely need the dimension name to be what you specified in the config, try removing the require_exact_match option from as many dimensions as possible, that way you may be able to register some more dimensions without it failing. Seems like it's now failing on the last dimension in the config...

Terra-B-Welch commented 3 years ago

Well that worked, setting it to WorldProviderSurfaceJED allows the world to load fine.