search

maruohon / litematica

A modern client-side schematic mod for Minecraft
GNU Lesser General Public License v3.0
730 stars 219 forks source link

Rotation for repeaters and comparators 90 degree off #170

Open NicklasE99 opened 4 years ago

NicklasE99 commented 4 years ago

In easyPlace mode and tweakAccurateBlockPlacement the repeaters and comparators are placed with a 90 degree incorrect rotation, i.e., they always get 90 degree wrong. When placing dropper, observers and pistons, there is no problem.

2020-05-02_11 37 00

placement_test.zip

vacla commented 4 years ago

Which version of litematica, minecraft version, singleplayer or server?

NicklasE99 commented 4 years ago

These are the mod versions: tweakeroo-fabric-1.15.2-0.10.0-dev.20200424.222527.jar minihud-fabric-1.15.2-0.19.0-dev.20200427.222110.jar malilib-fabric-1.15.2-0.10.0-dev.21+arne.1.jar litematica-fabric-1.15.2-0.0.0-dev.20200501.214810.jar itemscroller-fabric-1.15.2-0.15.0-dev.20200212.183513.jar carpet-extra-1.15.2-1.3.18.jar fabric-carpet-1.15.2-1.3.21+v200429.jar

Server running carpet mod with the same version as above.

maruohon commented 4 years ago

It looks like it's just the comparators, repeaters and trap doors which have another property as well, like the subtract mode, extra delay, top half trapdoor. So this is the same accurate placement protocol bug that also breaks top half stair placing which was reported a little while ago. I'll need to take a look at the protocol, I think it's currently overlapping some of those other property values into the facing data.

magneticflux- commented 3 years ago

I encountered the same issue. It might be an issue in carpet-extra; after reading the different implementations of the protocol, I found some differences between QuickCarpet and Carpet-Extra, particularly here:

https://github.com/gnembon/carpet-extra/blob/6e9e9070c09021bd7a7a0ed5b2b8a5871448cf16/src/main/java/carpetextra/utils/BlockPlacer.java#L114

https://github.com/QuickCarpet/QuickCarpet/blob/a4fa62ea870defa74658d74ec2fd46a49c8990f5/src/main/java/quickcarpet/utils/AccurateBlockPlacement.java#L57

Can someone test with QuickCarpet? I'm using Carpet-extra on my server right now.