maruohon / litematica

A modern client-side schematic mod for Minecraft
GNU Lesser General Public License v3.0
730 stars 221 forks source link

Cant save as .schematic file #207

Open averwhy opened 4 years ago

averwhy commented 4 years ago

This probably has been said before. but i'd like to bring extra attention to it

Minecraft version 1.16.1

Mod version and malilib version litematica-fabric-1.16.1-0.0.0-dev.20200630.022912 malilib-fabric-1.16.1-0.10.0-dev.21+arne.1

Description of the bug Saving as .schematic doesnt work

Expected behavior (if not clear from the description) Able to save schematics as .schematic files, so i can use it with Fabritone (baritone fork) ;)

SunSerega commented 4 years ago

.schematic format is outdated at least because schematica the mod is dead. And while @maruohon still want's to support it - i think it makes more sense to write issue in Fabritone or Baritone to support .litematica format.

maruohon commented 4 years ago

There are already a couple of issues on the Baritone issue tracker related to this: https://github.com/cabaletta/baritone/issues/668 https://github.com/cabaletta/baritone/issues/799

So basically the preferred solution IMO is that Baritone/Fabritone will support the Sponge schematic format (*.schem) which is widely used for MC 1.13+ elsewhere. I'm not sure if it does currently? Litematica supports that format in the 1.12.2 version, so that support will come to the other versions after I have the time to finish a number of other things that still should be done in the 1.12.2 code base before the 1.12.2 code can be ported to the 1.13.2+ versions again.

Litematica will also support conversion between all the formats. This already works in the 1.12.2 version, but for the 1.13.2+ versions it needs a bunch more work due to the old MCEdit *.schematic format needing special handling due to the old numerical block IDs that don't exist in MC 1.13+ anymore. Towards this end I have already made a block state conversion data map between 1.12.2 and 1.13.2, but the other conversion related code still needs a lot of work due to other complications such as having to move certain block properties/data between the block state and the block entity during that 1.12.2 <-> 1.13+ conversion (flattening related changes).

kamil004 commented 4 years ago

Hello ;) Ok so export as schematic is disabled/discontinued.... OK.... but.. Litematic file is usable only in creative mode.

If i try to re-build litematic file in survival, i can't. Because command farbritone "build name.litematic" dosn't work. I get error something like "write correct file name".

Only one way to working with fabritone or baritone is convert litematic file to schematic file. Also change name name.litematic to name.schematic dosn't work.

So only one way is install 1.12.2 and convert litematic file from 1.16.1 to schematic format? PS: need to use fabric or forge? or whatever? PS2: After that I will be able to build schematic in survival on 1.16.1 with fabritone?

maruohon commented 4 years ago

*.schematic export is not discontinued, it's just not yet implemented in the 1.13.2+ versions. Exporting back to the old numeric IDs based MCEdit/Schematica format requires me to have a full mapping from block states to the old numeric block IDs and metadata values, because the game doesn't have/use those anymore in 1.13+. This is what I was working on a while back, and I have that map in my dev code for 1.12.2 <-> 1.13.2. On the other hand support for exporting to the new Sponge schematic format also already exists in the 1.12.2 version, but that code just hasn't been ported to the 1.13.2+ versions yet. I'm still not sure which format fabritone/baritone uses.

So currently if you need a schematic in the Sponge format, you can paste it to a temporary world and then use World Edit to save it as a *.schem (Sponge schematic format). If you need it in the old MCEdit/Schematica format, then you should use Amulet (the new MCEdit) to downgrade that temporary world to 1.12.2 and then you can use 1.12.2 Litematica or Schematica or MCEdit-Unified to save it as a *.schematic.

SpikeVN commented 3 years ago

Maybe soneone could write a converter from .litematic to .schematic and .schem

HiRedVibes commented 5 months ago

hey I have an issue the schematics file is not a folder so i cant store anything in it

image
maruohon commented 5 months ago

@HiRedVibes Your screenshot is from the mods directory, the schematics directory is not inside there, it's one directory up, inside the main game instance directory.