maruohon / litematica

A modern client-side schematic mod for Minecraft
GNU Lesser General Public License v3.0
730 stars 219 forks source link

Request to add keys for "Generic", "Info Overlays", "Visuals", "Colors", "Hotkeys", "Render Layers" #607

Open Annijang opened 1 year ago

Annijang commented 1 year ago

Is your feature request related to a problem? Please describe. Hi, I'm converting the lang file from English to Chinese and I found these information in the settings without the key, I want to let more Chinese players to play your such a good work, can I ask you to add the key?

Describe the solution you'd like Add key

Describe alternatives you've considered Although I can build through the source code of github, I can't share your work with others without your authorization, so please add the key or give me the right to send the jar file to others. If you can give me the right to republish and distribute the jar file, I will share my good work to Chinese players for free, I will share my work in mcmod and mcbbs, the two largest minecraft communities in China, Thank you.their links are: "https://www.mcmod.cn/ " and "https://www.mcbbs.net/"

Additional context image

maruohon commented 1 year ago

All of these have localization keys added in the main development code, which is in the liteloader_1.12.2 branch. I'm not going to change this stuff in the old code anymore, which is currently still used in all of the current 1.13+ mod versions. The new code is meant to become the code base for all mod versions, when I just have time and energy to continue working on it and get it ready for releases. Unfortunately I don't have any real timeline for this currently.

Annijang commented 1 year ago

All of these have localization keys added in the main development code, which is in theliteloader_1.12.2branch. I'm not going to change this stuff in the old code anymore, which is currently still used in all of the current 1.13+ mod versions. The new code is meant to become the code base for all mod versions, when I just have time and energy to continue working on it and get it ready for releases. Unfortunately I don't have any real timeline for this currently.

Okay, I understand, I have used your source code to localize Chinese and build successfully, can you give me permission to share 'jar' in "mcmod" and "mcbbs"? I will give a curseforge link, I made version 1.18.2fabric. They are free yes, I will not claim that the author of the work is me, I just want more Chinese players to use this excellent work of yours.

maruohon commented 1 year ago

Actually did you try with the MasaGadget mod? I think it had a feature where it patches my mods to have localization keys for the configs and config categories. Then you wouldn't need to distribute a modified version of Litematica itself.

But if you don't want to do that, then I guess for now you can upload your version. Just indicate that if there are issues with those versions then the players should try with the official version before reporting issues to me. And also once I get the new mod versions out at some point that are based on the new code and have support for this directly, please update the posts to indicate that there are new official versions that should be used instead.

Annijang commented 1 year ago

Actually did you try with theMasaGadgetmod? I think it had a feature where it patches my mods to have localization keys for the configs and config categories. Then you wouldn't need to distribute a modified version of Litematica itself.

But if you don't want to do that, then I guess for now you can upload your version. Just indicate that if there are issues with those versions then the players should try with the official version before reporting issues to me. And also once I get the new mod versions out at some point that are based on the new code and have support for this directly, please update the posts to indicate that there are new official versions that should be used instead.

Thank you for letting me know about the 'MasaGadget mod', except I don't need it yet because I can modify it directly in the source code you provided, but thanks for letting me know about such a great tool!

If so can I ask you to update the 'zh_cn.json' file of the 1.18.2fabric for me as well? I reset a lang version because someone else's language file had an error before, thank you. litematica-fabric-1.18.2-0.11.3.zip

I see "Pick Block Hotkeys" and "Placement Restriction" after lines 74 and 77 in the Chinese version, can I convert them to Chinese? Are they unmodifiable elements in the code? image

maruohon commented 1 year ago

You can localize those, they are used as the toggle message names. Actually the first argument, which is the config's internal name, is "more dangerous" to rename. I don't remember if the unicode handling in the config read/write code was fixed in the 1.18.2 version or which version exactly.

Annijang commented 1 year ago

You can localize those, they are used as the toggle message names. Actually the first argument, which is the config's internal name, is "more dangerous" to rename. I don't remember if the unicode handling in the config read/write code was fixed in the 1.18.2 version or which version exactly.

I have only converted the information within 'Generic' to Chinese so far, and have not found anything different so far. I will keep a version where the first name has not been converted to Chinese available for others to download, thank you for your efforts, it will definitely pay off.

Annijang commented 1 year ago

You can localize those, they are used as the toggle message names. Actually the first argument, which is the config's internal name, is "more dangerous" to rename. I don't remember if the unicode handling in the config read/write code was fixed in the 1.18.2 version or which version exactly.

When I was making Chinese I found a wrong text in line 235, according to the code quoted earlier, 'The X offset' -> 'The Y offset' image

TaoismDeepLake commented 1 year ago

I built that 1.12.2 forge jar with the code he/she provided, but I didn't change things like version number. I hope that's okay.