maruohon / litematica

A modern client-side schematic mod for Minecraft
GNU Lesser General Public License v3.0
735 stars 223 forks source link

Litematica is not saving item frames or paintings in schematics. #640

Open gitsh01 opened 1 year ago

gitsh01 commented 1 year ago

I saved a schematic of a build, but the item frames and the paintings are not preserved. They were working in earlier builds on 1.19.2 (sorry, don't remember which version).

It appears to be broken in .litematic files.

Here's a project I tried saving, that is missing item frames and paintings: https://www.planetminecraft.com/project/desert-grand-library/

As you can see in the video, the paintings and item frames are there, but when you open the .litematic, they're gone. That site only accepts .nbts, which were created using the vanilla export in litematica, but they're gone in the original .litematic too. Attached original .litematic in a zip format below. desert_grand_library.zip

If you want the map file let me know, but it's huge. I don't think it's related to the map, I've had this happen on a smaller build as well.

maruohon commented 1 year ago

They are in the schematic file, but I get spammed in the console with

[13:05:25] [Render thread/ERROR]: Hanging entity at invalid position: class_2338{x=-15, y=79, z=-69}
[13:05:25] [Render thread/ERROR]: Hanging entity at invalid position: class_2338{x=-16, y=80, z=-69}

when I load the schematic. So they just fail to get loaded and placed to the schematic world. I'll have to take a closer look at the code.

maruohon commented 1 year ago

It loads fine in 1.18.2, so this must have been a 1.19.x vanilla change in the hanging entity class.

johnnygoboy commented 1 year ago

I'm finding an issue where entities aren't being loaded when the schematic is rendered visually but they appear when I load in. could this be related or something else?

electricsteve commented 1 year ago

They are in the schematic file, but I get spammed in the console with

[13:05:25] [Render thread/ERROR]: Hanging entity at invalid position: class_2338{x=-15, y=79, z=-69}
[13:05:25] [Render thread/ERROR]: Hanging entity at invalid position: class_2338{x=-16, y=80, z=-69}

when I load the schematic. So they just fail to get loaded and placed to the schematic world. I'll have to take a closer look at the code.

I have the same issue. Is there a fix for it yet?