maruohon / litematica

A modern client-side schematic mod for Minecraft
GNU Lesser General Public License v3.0
689 stars 191 forks source link

Update to 1.20 #712

Closed y2k04 closed 1 year ago

y2k04 commented 1 year ago

I used ekgame/malilib (pre-rewrite/fabric/1.20.x) which works completely fine.

Bug that I caused: Material List block icons are empty. image

I forgotten which class renders the icons in the material list, could someone please remind me?

vacla commented 1 year ago

@y2k04 see: https://github.com/maruohon/malilib/pull/126#issuecomment-1586179815

y2k04 commented 1 year ago

@y2k04 see: maruohon/malilib#126 (comment)

What forks?

vacla commented 1 year ago

Like https://github.com/kosmolot-mods/litematica that currently most ppl are using for 1.20

y2k04 commented 1 year ago

Ohh thanks, but I will be keeping this pull request up.

Fradid commented 1 year ago

Why i cant compile kosmolot-mods/litematica? it says you dont have malilib-1.20-0.16.0.jar, but i do

y2k04 commented 1 year ago

Why i cant compile kosmolot-mods/litematica? it says you dont have malilib-1.20-0.16.0.jar, but i do

You have to add malilib-1.20-0.16.0.jar and malilib-1.20-0.16.0.pom to %userprofile%\.gradle\fabric-loom\minecraftMaven\fi\dy\masa\malilib\malilib-fabric-1.20\0.16.0. You will probably need to make the folders yourself.

I have attached malilib-1.20-0.16.0.pom but you will need to remove .txt from the end of it.

malilib-fabric-1.20-0.16.0.pom.txt

Fradid commented 1 year ago

oh yeah, this is just what I needed, I couldn't find the file. ty so much!

y2k04 commented 1 year ago

I have been testing out the unofficial version of Litematica by kosmolot and it has been a lot better and doesn't have the issue of the item icons in the material list not being drawn. If you go to the Modrinth page for it, download the .mrpack, open it in 7-Zip or something similar, go into the override folder and extract Litematica and MaliLib. It works fine.

maruohon commented 1 year ago

@y2k04 Are you saying the item rendering is broken in the official release for you? It seems to work in my test instance at least.

y2k04 commented 1 year ago

@y2k04 Are you saying the item rendering is broken in the official release for you? It seems to work in my test instance at least.

In my fork, the items in the material list don't render.