Loading world crash (99% sure due to breaking sodium changes)

AlienXtream commented 3 months ago

Please don't post simple questions on this issue tracker!

Simple questions like "How do I do X?" should instead be handled either on the Discussions area (see on the top of the page) or on Discord:

My Discord server: https://masa.dy.fi/discord -> #litematica
or the SciCraft Discord: https://discord.gg/scicraft -> #masas-mods Every message on the issue tracker here sends an email to me, and a message on two Discord servers. So having simple support conversations here gets really spammy and annoying. Please use one of the above mentioned alternatives instead.

Other rules

Before reporting an issue, please make sure it has not already been fixed in a later version! Also make sure you have the latest version of both Litematica and malilib! There are occasionally changes that will require both mods to be updated at the same time, or something will break!
- There are occasionally development versions here: https://masa.dy.fi/mcmods/client_mods/
- Also check on CurseForge: https://www.curseforge.com/minecraft/mc-mods/litematica/files
- See which page has the latest version. Starting with Minecraft 1.17, I will not keep all the mods for the current Minecraft version on my server anymore. There are now only mod builds on my server leading up to a new version on CurseForge. So in other words, if the mod is listed on my server, then it should be the latest version. If it's not there at all, then the latest version is on CurseForge. But check both just in case, to see what the latest version is.
No snapshot issues - Don't post issues for mod versions made for Minecraft snapshots on this tracker. The snapshot versions aren't "properly" supported or tested. Snapshot versions (when or if they are available) are only provided as quick ports (when I have the time and motivation to make them) in a "might work, mostly" basis. Any issues with snapshot versions should rather be handled on Discord, see above.

Provide at least the following information

Minecraft version - Which Minecraft version are you playing on?
Mod version and malilib version - Which exact mod version are you using?
- Include the full mod file name which includes the build date and time for the development versions, or you can see the mod version in the title of the Litematica main menu.
- "Latest" is not a version!! It's ambiguous, it's a moving target, and very often the version is not actually even the latest available version at that time.
A clear description of the issue - I'm not a psychic, so you have to describe the issue thoroughly enough for me to be able to reproduce it without knowing anything at all that is not described in the issue report.

Fabric 0.15.7 Minecraft 1.20.1 MLib 0.16.3 Litematica 15.3 Sodium 0.5.8

Crash when loading or creating world. crash is consistent with incompatability with breaking changes in current sodium version. it seems "SodiumWorldRenderer" has been replaced with different methods and so mods that implemented sodium suppoprt need to update their compatability layer to the new methods.

crash-2024-03-28_13.41.47-client.txt

sakura-ryoko commented 3 months ago

if I were you, I would downgrade your Sodium to 0.5.6, because it is more compatible with your other mods, such as sodium-extra, and Iris.

Also, you have A TON of mods installed, so I would recommend running Minecraft (Fabric of course) with Sodium, Malilib, and litematica only and try to reproduce your problem. Running a TON of mods together is generally never a good idea, unless you are 100% sure that they are all 100% compatible with each other, where clearly you are having a mod conflict.

maruohon commented 3 months ago

java.lang.ClassCastException: class fi.dy.masa.litematica.world.WorldSchematic cannot be cast to class net.minecraft.class_638 (fi.dy.masa.litematica.world.WorldSchematic and net.minecraft.class_638 are in unnamed module of loader net.fabricmc.loader.impl.launch.knot.KnotClassLoader @7e0b0338)
    at me.jellysquid.mods.sodium.client.render.SodiumWorldRenderer.redirect$nnb000$valkyrienskies$renderShipBlockEntityInShipyard(SodiumWorldRenderer.java:1572)

Seems like an issue in Valkyrien Skies?

AlienXtream commented 3 months ago

might be. i just recognised the issue as similar to the known sodium issue. if others are aboe to run sodium 0.5.8+ with litematica then i guess i was wrong. i just assumed the VS mixin was unrelated. a bad call on my part if that's not the case (of which i apologise)

maruohon commented 3 months ago

There have been some cases reported earlier as well where some mods assume things to be of certain type, and they try to cast it to some given type without checking instanceof first. And then things crash when it wasn't actually of that type.

So here it looks like Valkyrien Skies assumes that the world the renderer gets always is or extends the vanilla ClientWorld class. But Litematica's schematic world doesn't extend the ClientWorld class, because it was simpler to extend one of the parent classes for my use case.

maruohon / litematica