Drew-Chase commented 1 year ago

Issue

When in the nether while looking through the Immersive Portal to the Overworld my FPS drops from 60 to 20 and the debugger it says malilib_renderworldlast is using ~27% total resources

Debug Tree

root
gameRenderer
level
render_portal_total
render_portal_content
malilib_renderworldlast

Instance Information

Versions

Minecraft: 1.19.3
Fabric: 0.14.14
JDK : 17.0.4.101
Modlist
- AdditionalStructures-1.19.x-(v.4.1.1).jar
- advancementinfo-1.19.3-fabric0.68.1-1.3.1.jar
- AmbientSounds_FABRIC_v5.2.17_mc1.19.3.jar
- Amplified_Nether_v1.2.jar
- animatica-0.5+1.19.jar
- antighost-1.19.3-fabric0.68.1-1.1.5.jar
- anvilrestoration-1.19.3-2.0.jar
- appleskin-fabric-mc1.19.3-2.4.2.jar
- architectury-7.1.70-fabric.jar
- AttributeFix-Fabric-1.19.3-18.0.1.jar
- authme-mc1.19.3-5.0.0.jar
- badpackets-fabric-0.3.4.jar
- balm-fabric-1.19.3-5.0.2.jar
- BeaconOverhaul-1.7.5+1.19.3.jar
- beautifiedchatserver-1.19.3-2.2.jar
- betterbeaconplacement-1.19.3-3.1.jar
- betterbeds-1.3.0-1.19.3.jar
- BetterF3-5.1.0-Fabric-1.19.3.jar
- bettermounthud-1.2.1.jar
- BetterPingDisplay-Fabric-1.19.3-1.1.1.jar
- betterstats-2.2.1+1.19.3.jar
- BetterTags-1.19.3-Fabric-v1.0.jar
- betterthanmending-1.3.0.jar
- BiomeParticleWeather-v4.0.4-1.19.3-Fabric.jar
- blur-2.6.1.jar
- boathud-1.1.2.jar
- Bookshelf-Fabric-1.19.3-17.0.3.jar
- borderless-mining-1.1.6+1.19.3.jar
- BowInfinityFix-1.19.x-fabric-2.5.0.jar
- BuildingWands_mc1.19.3-2.6.5_beta-fabric.jar
- Capes-1.5.1+1.19.3.jar
- carpet-extra-1.19.3-1.4.91.jar
- carryon-fabric-1.19.3-2.0.4.15.jar
- cem-0.7.2.jar
- CITResewn-1.1.3+1.19.3.jar
- ClearDespawn-fabric-1.19.2-1.1.10.jar
- clickadv-fabric-3.0.jar
- clickthrough-1.19.3-fabric0.68.1-0.4.jar
- cloth-config-9.0.94-fabric.jar
- Clumps-fabric-1.19.3-9.0.0+16.jar
- collective-1.19.3-6.48.jar
- compacthelpcommand-1.19.3-2.1.jar
- connectivity-fabric-1.19.3-3.9.jar
- Controlling-fabric-1.19.3-10.0+9.jar
- CosmeticArmor-1.19.3-1.4.1.jar
- CreativeCore_FABRIC_v2.10.4_mc1.19.3.jar
- cullleaves-fabric-3.0.3.jar
- deathlog-0.3.1+1.19.3.jar
- Debugify-1.19.3+1.1.jar
- dragonloot-1.1.3.jar
- dynamic-fps-2.2.0.jar
- easiervillagertrading-1.19.3-fabric0.68.1-1.5.4.jar
- EditSign-1.19.3-2.7.0.jar
- emi_loot-0.6.1+1.19.3.jar
- emi-0.6.4+1.19.3.jar
- EMITrades-fabric-1.1.0+mc1.19.3.jar
- EnchantmentDescriptions-Fabric-1.19.3-14.0.4.jar
- endportalrecipe-1.19.3-5.0.jar
- entity_texture_features_fabric_1.19.3-4.3.1.jar
- entityculling-fabric-1.5.2-mc1.19.3.jar
- EquipmentCompare-1.19.3-fabric-1.3.2.jar
- Essential-fabric_1-19.jar
- exordium-fabric-1.0.3-mc1.19.3.jar
- extended-armor-bars-1.2.1.jar
- extremesoundmuffler-3.35-fabric-1.19.3.jar
- fabric-api-0.73.2+1.19.3.jar
- fabric-carpet-1.19.3-1.4.96+v230201.jar
- fabric-language-kotlin-1.9.1+kotlin.1.8.10.jar
- fabricskyboxes-0.6.2+mc1.19.3.jar
- fabrishot-1.9.1.jar
- fallingleaves-1.14.5+1.19.3.jar
- farsight-fabric-1.19-3.4.jar
- fastback-0.8.0+1.19.3.jar
- Fastload+1.19.3-2.6.11.jar
- fastquit-2.1.0+1.19.3.jar
- fat-experience-orbs-2.0.1+1.18-fabric.jar
- ferritecore-5.1.0-fabric.jar
- ForgeConfigAPIPort-v5.0.9-1.19.3-Fabric.jar
- fsb-interop-1.1.4+mc1.19.3-build.30.jar
- heartytrinkets-1.19.3-1.0.0.jar
- hiddenrecipebook-1.19.3-4.0.jar
- Iceberg-1.19.3-fabric-1.1.4.jar
- ImmediatelyFast-1.1.8+1.19.3.jar
- immersive_armors-1.5.4+1.19.3-fabric.jar
- immersive-portals-2.5.1-mc1.19.3-fabric.jar
- incantationem-1.2+1.19.3.jar
- indium-1.0.14+mc1.19.3.jar
- InventorySorter-1.8.10-1.19.3.jar
- inventorytotem-1.19.3-3.0.jar
- InvView-1.4.10-1.19.3+.jar
- iris-mc1.19.3-1.5.2.jar
- IronChests-1.7.8.jar
- itemscroller-fabric-1.19.3-0.18.0.jar
- jamlib-0.6.0+1.19.3.jar
- krypton-0.2.1.jar
- lambdynamiclights-2.2.0+1.19.3.jar
- language-reload-1.5.4+1.19.3.jar
- lazydfu-0.1.3.jar
- ledger-1.2.6.jar
- letmedespawn-1.18.x-1.19.x-fabric-1.0.2.jar
- litematica-fabric-1.19.3-0.13.1.jar
- litematica-printer-1.19.3-3.1.jar
- lithium-fabric-mc1.19.3-0.10.4.jar
- main-menu-credits-1.1.1.jar
- malilib-fabric-1.19.3-0.14.0.jar
- memoryleakfix-1.19.3-0.7.0.jar
- midnightcontrols-1.7.3+1.19.3.jar
- midnightlib-fabric-1.1.0.jar
- minihud-fabric-1.19.3-0.25.0.jar
- MixinConflictHelper-1.2.0.jar
- mixintrace-1.1.1+1.17.jar
- modelfix-1.10-fabric.jar
- modmenu-5.0.2.jar
- MoreAchievements-1.19.3-1.0.10.jar
- moreadvancementsmod-1.2.2-1.19.3.jar
- morechathistory-1.19.1-1.1.1.jar
- moreculling-1.19.3-0.16.0.jar
- moremcmeta-1.19.3-3.0.6-fabric.jar
- mythicupgrades-fabric-1.6-BetaPreview3-1.19.3.jar
- nametagtweaks-1.19.3-3.0.jar
- netherportalfix-fabric-1.19.3-11.0.1.jar
- no-resource-pack-warnings-1.0.0.jar
- NoChatReports-FABRIC-1.19.3-v2.0.0.jar
- nofade-1.18-2.0.1.jar
- NoFog-1.3.2_1.16.5-1.19.3-fabric.jar
- observable-4.3.1.jar
- OfflineSkins-1.19.3-v1-fabric.jar
- optigui-1.1.6.jar
- owo-lib-0.10.2+1.19.3.jar
- oxidized-1.8.0.jar
- panorama-1.2.0 - 1.19.3.jar
- Patchouli-1.19.3-78-FABRIC.jar
- PetOwner-1.8.4-1.19.3+.jar
- pistorder-mc1.19.3-v1.5.0-fabric.jar
- Prism-1.19.3-fabric-1.0.4.jar
- puzzle-1.4.2-1.19.3.jar
- quickshulker-1.3.10-1.19.3.jar
- reacharound+1.19.3-1.1.2.jar
- reeses_sodium_options-1.4.9+mc1.19.2-build.67.jar
- repurposed_structures-6.3.15+1.19.3-fabric.jar
- right-click-harvest-3.1.0+1.19.3.jar
- RingOfEnderchest-Fabric-1.19.3-rc1-1.4.5.jar
- servertick-mc1.19-1.7.jar
- ShowMeWhatYouGot-1.19.3-1.1.0.jar
- smoothchunk-fabric-1.19.3-3.0.jar
- sodium-extra-0.4.17+mc1.19.3-build.95.jar
- sodium-fabric-mc1.19.3-0.4.9+build.23.jar
- soundphysics-fabric-1.19.3-1.0.18.jar
- splash_milk-1.19.3-1.3.0.jar
- starlight-1.1.1+fabric.ae22326.jar
- Structory-1.19-v1.3.jar
- suggestion-tweaker-1.19.1-1.3.1-fabric.jar
- syncmatica-1.18.2-0.3.8.jar
- TerraBlender-fabric-1.19.3-2.1.0.139.jar
- terrestria-5.1.1.jar
- toms_storage_fabric-1.19.3-1.5.0.jar
- ToolStats-Fabric-1.19.3-13.0.1.jar
- tooltipfix-1.1.1-1.19.3.jar
- trade-cycling-fabric-1.19.3-1.0.5.jar
- traverse-6.1.2.jar
- trinkets-3.5.1.jar
- tweakeroo-fabric-1.19.3-0.15.0.jar
- veinmining-fabric-1.0.1+1.19.3.jar
- visuality-0.6.0.jar
- weaponmaster-client-only-fabric-1.19.3-3.0.5.jar
- WilderWild-1.1.13-Fabric+1.19.3.jar
- wolf-armor-compat-1.0.3-1.19.2.jar
- wraith-waystones-3.0.6+mc1.19.3.jar
- wthit-fabric-6.1.4.jar
- Xaeros_Minimap_23.1.0_Fabric_1.19.3.jar
- XaerosWorldMap_1.28.9_Fabric_1.19.3.jar
- YetAnotherConfigLib-2.2.0.jar
- yosbr-0.1.1.jar
- youre-in-grave-danger-1.5.1.jar
- zergatul.freecam-1.5.0-fabric-1.19.3.jar
- Zoomify-2.9.2.jar

maruohon commented 1 year ago

Does the FPS recover if you toggle off MiniHUD main rendering (H) or Litematica main rendering (M + R)? If so, which one individually or both together?

Drew-Chase commented 1 year ago

it does not

Drew-Chase commented 1 year ago

Here is a video I recorded of the issue

maruohon commented 1 year ago

Are you currently using Fabulous graphics? Then try switching to Fancy to see if that slow malilib_renderworldlast section disappears then.

Because I just found a few lines of code in that malilib render event handler that I have no recollection what they were for... But that piece of code only runs in the Fabulous graphics mode.

If it's not that, then try taking out MiniHUD and Litematica completely, and see if that malilib section is still high up in the profiler. It shouldn't do anything without any registered mod render handlers, except if you are in Fabulous mode, where it does those couple of extra calls that I don't remember why they are there... They were probably to fix some kind of issue somewhere...

Drew-Chase commented 1 year ago

So I removed malilib and all mods requiring it and it issue still persists this time it says "weather" is the issue... I should have checked this first, I apologize for bothering you.

P.S.

Love your mods!

maruohon commented 1 year ago

Okay. And thanks!

TBF I would pretty much expect there to be a fairly noticeable performance hit when you are essentially rendering two worlds simultaneously. It's just rather weird how it showed up in the malilib profiler section, unless it was actually malilib also (further?) slowing things down.

maruohon / malilib

Immersive Portals Issue #116

Issue

Debug Tree

Instance Information

Versions

Modlist

P.S.