search

maruohon / malilib

Library mod for masa's client-side Minecraft mods
GNU Lesser General Public License v3.0
294 stars 124 forks source link

[Suggestion] Use GuiColorEditorHSV #74

Closed Zailer43 closed 2 years ago

Zailer43 commented 2 years ago

By creating a ConfigColor and clicking on the color rectangle to the right of the field one would expect to be able to choose the color in some more graphical way, but this is not the case, looking at the library code I saw that GuiColorEditorHSV exists since 2019 and i saw that it is not used

image GuiColorEditorHSV

maruohon commented 2 years ago

It has been used in the 1.12.2 code base probably since late 2019, but all the 1.13+ versions are still based on 1.12.2 code from early June 2019, and the 1.12.2 code hasn't been merged to the 1.13+ versions since then. I think currently just MiniHUD uses the color editor screen for some shapes, but none of the config widgets in that old code hooked up the color editor screen to the color indicator widget yet.

So basically yes all the configs will be/are using it, just not in the 1.13+ code base yet. I'm currently still working on major malilib rewrites in 1.12.2, after which I'll be working on rewriting and cleaning up the other mods. There is a huge amount of stuff on my todo list still, so I can't give any kind of meaningful ETA for when the 1.12.2 code is ready to be ported forward again.