maruohon / minihud

A client-side Minecraft mod with configurable "info lines" ("mini-F3") and various overlays, such as light level and structure bounding boxes
GNU Lesser General Public License v3.0
418 stars 118 forks source link

[1.12.2] Conflict with RandomPatches. Game crashes upon startup. #169

Open SonicX8000 opened 3 years ago

SonicX8000 commented 3 years ago

Refer'd Issue: https://github.com/TheRandomLabs/RandomPatches/issues/246

Minecraft: 1.12.2 Forge: 14.23.5.2854

Mods: 5 [MixinCompat-0.8] _MixinBootstrap-1.1.0 malilib-forge-1.12.2-0.10.0-dev.23 minihud-forge-1.12.2-0.19.0-dev.20210503.192331 randompatches-1.12.2-1.22.1.10

=====

For some reason using these dev versions of minihud & malilib causes a crash to occur upon startup with RandomPatches. If I don't have RandomPatches installed, then no crash occurs. No crash report occurs when this happens and also "minihud-1.12.2-0.13.1" didn't cause this crash to occur.

Log: https://hastebin.com/sucezimuju.sql

Reason I use the dev versions is because you have the TPS & Memory which isn't present in "minihud-1.12.2-0.13.1.jar".

Note Mixin Compact is needed if you are using Dynamic surroundings, however that mod wasn't present when testing. The game still crashes without "[MixinCompat-0.8]".

maruohon commented 3 years ago
[01:10:28] [main/FATAL] [mixin]: Mixin prepare failed preparing MixinGuiScreen in mixins.minihud.json: org.spongepowered.asm.mixin.transformer.throwables.MixinTargetAlreadyLoadedException Critical problem: mixins.minihud.json:MixinGuiScreen target net.minecraft.client.gui.GuiScreen was loaded too early.
org.spongepowered.asm.mixin.transformer.throwables.MixinTargetAlreadyLoadedException: Critical problem: mixins.minihud.json:MixinGuiScreen target net.minecraft.client.gui.GuiScreen was loaded too early.

It seems that RandomPatches somehow causes the GuiScreen class to get loaded too early, before Mixin has a chance to apply the injectors from my mods. There is nothing to be done for that from my side, that would need to be fixed in RamdomPatches.