search

maruohon / minihud

A client-side Minecraft mod with configurable "info lines" ("mini-F3") and various overlays, such as light level and structure bounding boxes
GNU Lesser General Public License v3.0
420 stars 120 forks source link

Weird mob and texture layering offset at certain perspectives #82

Open JoshWilger opened 4 years ago

JoshWilger commented 4 years ago

Mods versions: MaLiLib malilib-fabric-1.16.2-0.10.0-dev.21+arne.1 MiniHUD minihud-fabric-1.16.2-0.19.0-dev.20200819.013355

I've had a rendering issue for quite a while (not long after I first started using mods 4 months ago or so), but the annoyance of it has finally got to me. I've limited the problem down to MiniHUD, but I don't really know what information you need in order to reproduce and fix the problem. I tried to refresh the config file in .minecraft/config/minihud in order to see if it had to do with a setting messing things up, but when I removed the file it just came back.

THE PROBLEM I have attached a host of screenshots to show the issues I have encountered time and time again; this includes: (1) mob textures for things like creepers (that seem to only have one texture layer) being completely offset and seem "invisible" because the texture model isn't in the right position and sometimes off-screen; (2) outside texture layer on many layered textures, such as the outer opaque beacon beam, elytra wings, wool on sheep, drowned outer skin layer, guardian outer skin layer, etc. I don't think I have come across both problems combined, though. Both problems are only seen from certain perspectives, meaning that most of the time things are lined up and look correctly, but various angles will offset the texture models and moving the player will move the models consistently in various directions from the correct position.

I have also attached my Malilib and Minihud configs in .txt form in the hopes that you will be able to reproduce the issue I am having. Let me know if you need any other info or have troubles reproducing the problem.

Love your mod otherwise <3 -Happy

2020-08-20_11 47 08 2020-08-20_11 47 11 2020-08-20_11 54 50 2020-08-20_11 54 56 2020-08-20_11 57 03 2020-08-20_11 43 28 2020-08-20_11 44 46 2020-08-20_11 44 58 2020-08-20_11 47 00

malilib.txt minihud.txt

maruohon commented 4 years ago

AFAIK things rendering at weird incorrect positions is caused by some kind of state leak in some of the vanilla debug renderers ever since 1.15. I'm not sure if the renderers are broken, or if I'm just calling them from a different/wrong place during the rendering phase compared to where they would be in Mojang's internal code (in the shipped game they are not called from anywhere, except for the chunk border debug renderer). I have meant to try to add a fix for this, but haven't gotten around to it yet. In your config you seem to have two of the debug renderers enabled:

    "debugNeighborsUpdateEnabled": true,
    "debugPathfindingEnabled": true,

So at least try disabling those first and see if the issue goes away. I guess I'll try to take a look if I can find what in the renderers breaks the rendering and try to add a fix for it at some point soon.

JoshWilger commented 4 years ago

It appears to have worked! Thank you so much!