search

maruohon / tweakeroo

A client-side Minecraft mod that adds various "tweaks" (= usually small-ish individual features)
GNU Lesser General Public License v3.0
474 stars 128 forks source link

Freecam issue + feature request #141

Open supsm opened 3 years ago

supsm commented 3 years ago

I've noticed that when I toggle freecam in mid-air, I take no fall damage. Also, maybe add a "dummy" so the player knows where they are?

maruohon commented 3 years ago

I need to take yet another look at the free camera implementation, as apparently there are still many weird issues with it... Which MC version and mod version are you using? Some of these were supposed to be fixed in the second version, which is currently in 1.12.2 and 1.16.4.

As to rendering the player, the player is normally supposed to be rendered when you are in Free Camera mode, and it works in my test instance. I'm assuming you have another rendering related mod, such as Optifine or Sodium or Canvas that might be breaking this? (I haven't tested which ones work or break this specific thing.)

jkmartindale commented 3 years ago

I've noticed that when I toggle freecam in mid-air, I take no fall damage

I had the opposite experience, where entering freecam in mid-air would save the distance I'd already fallen and apply that amount of fall damage once I exit freecam, even if I had broken my fall with water or something else while in freecam.

Fabric loader: 0.10.8-1.16.4
malilib: fabric-1.16.4-0.10.0-dev.21+arne.2
Tweakaroo : fabric-1.16.4-0.10.0-dev.20201110.132827

jkmartindale commented 3 years ago

Actually nvm, what I got wasn't the opposite at all. In freecam you don't take fall damage no matter what (and pressure plates don't trigger). I got confused because I was testing with a mid-air water block and forgot to test without. Once you either leave freecam or enter player movement mode inside freecam, you take the "stored" damage (not the appropriate amount of damage based on your path during freecam).

supsm commented 3 years ago

Also, apparently there is a "dummy" player, it just isn't visible in canvas :D

jkmartindale commented 3 years ago

To add to the mystery, it looks like on 1.16 exiting freecam while falling in an area where there are no blocks beneath you (just void) seems to teleport you back up to where your player was when you entered freecam.

maruohon commented 3 years ago

These position issues are so weird, because the free camera mode is supposed to only block the player inputs going to the normal client player. I don't know how the server side position syncing is breaking, unless it's related to the camera entity not being the client player and the client not syncing the position normally, or something similar to that.