search

maruohon / tweakeroo

A client-side Minecraft mod that adds various "tweaks" (= usually small-ish individual features)
GNU Lesser General Public License v3.0
485 stars 134 forks source link

Crash with 5zig mod #174

Open UltraBlackLinux opened 3 years ago

UltraBlackLinux commented 3 years ago

Hey, there, I was just wondering, what this here was: 

[16:47:35] [main/FATAL]: Mixin apply failed the5zigmod.mixins.json:MixinGuiChatNew -> net.minecraft.class_338: org.spongepowered.asm.mixin.injection.throwables.InvalidInjectionException Variable modifier target for net/minecraft/class_338::getComponent was removed by another injector [INJECT Applicator Phase -> the5zigmod.mixins.json:MixinGuiChatNew -> Apply Injections ->  -> Inject -> the5zigmod.mixins.json:MixinGuiChatNew->@ModifyVariable::getComponent(Lnet/minecraft/class_303;)Lnet/minecraft/class_303;]
org.spongepowered.asm.mixin.injection.throwables.InvalidInjectionException: Variable modifier target for net/minecraft/class_338::getComponent was removed by another injector [INJECT Applicator Phase -> the5zigmod.mixins.json:MixinGuiChatNew -> Apply Injections ->  -> Inject -> the5zigmod.mixins.json:MixinGuiChatNew->@ModifyVariable::getComponent(Lnet/minecraft/class_303;)Lnet/minecraft/class_303;]

Your mod seems to remove this for some reason, why? oop 5zig seems to remove it :smort: oop²: it must be your mod @Redirect(method = "drawChat", at = @At(value = "INVOKE", target = "Lnet/minecraft/client/gui/GuiNewChat;drawRect(IIIII)V", ordinal = 0)) Facepalm: I was looking into the liteloader branch lol - still wondering, because the Fabriv 1.16.4 doesn't seem to have the GuiNewChat mixin.... Thanks!

maruohon commented 3 years ago

Tweakeroo does not remove anything, AFAIK that is not even possible with Mixins.

I believe the corresponding Mixin in the 1.16 version is this: https://github.com/maruohon/tweakeroo/blob/fabric_1.16_temp_features/src/main/java/fi/dy/masa/tweakeroo/mixin/MixinChatHud.java So I assume it's a conflict in the @ModifyVariable for a similar feature/change made by both mods?