maruohon / tweakeroo

A client-side Minecraft mod that adds various "tweaks" (= usually small-ish individual features)
GNU Lesser General Public License v3.0
482 stars 133 forks source link

1.20.1: disableSignGui also prevent editing signs #441

Open MeeniMc opened 1 year ago

MeeniMc commented 1 year ago

In yeets, we find the awesome option disableSignGui.

In prior versions of MC (i.e., until 1.19.4) the only time this window would show up was when placing a new sign.

In MC 1.20+ one can also right click a sign to edit it when it is already placed in the world.

The Yeet applies to both cases. Ideally, it would apply only to the first one (that is, only when placing a new sign).

Pietagorh commented 1 year ago

I'd like that to be an option, because I find a use in not having the sign edit gui pop up when I missclick on a sign (like if I forget to sneak and I want to place something on top of it) + you can bind a key to that yeet and just deactivate it when you wanna edit something

maruohon commented 1 year ago

The sign related tweaks and yeets in general need to be rewritten at some point to work properly with the 1.20 changes. I just didn't feel like spending the time to rewrite all of them in the initial 1.20 update based on the old mod code. I'll probably rewrite them once I first port the new code from 1.12.2 to 1.20 at some point.