Closed utzcoz closed 6 years ago
This looks good to me.
One nitpick: I think we can improve the enable and disable scripts slightly by using some shell scripting best practices like making sure to add the "#!/bin/sh" or "#!/bin/bash" header depending on which shell features are needed, double-quote all variable expansions to avoid potential word splitting, etc. But if you have tested it works, then it's fine. I can improve the scripts later.
One question: what's the size of the final rootfs image after adding xinput as a dependency?
@pdsouza I have added "#!/bin/bash
" for all scripts. The final desktop image's size with xinput is 224MB
.
@utzcoz Great, that should be good. I was asking because on some of our older devices, space on /system
is very limited. Thanks.
@utzcoz Merged!
The
blueprints
part to enable dynamic input switching. For the whose view, please visit the issue Enable dynamic input switching.