search

marvel-nccr / ansible-role-aiida

An ansible role that installs and configures AiiDA on Ubuntu.
Other
2 stars 5 forks source link

re-fix systemd templates #50

Closed ltalirz closed 3 years ago

ltalirz commented 3 years ago

Test that AiiDA daemon is running at the end of CI. Uses more convenient "block/rescue" syntax.

Also re-fixes systemd templates which were effectively broken (during my manual tests, I somehow came to believe that %I was the right way - it turns out that %i seems to be... unfortunately the documentation of systemd doesn't really help)

chrisjsewell commented 3 years ago

hey you requested my review, but it looks like you are still working on this?

ltalirz commented 3 years ago

sorry, done! (tests finally pass) ;-)

ltalirz commented 3 years ago

ping

chrisjsewell commented 3 years ago

Also re-fixes systemd templates which were effectively broken (during my manual tests, I somehow came to believe that %I was the right way - it turns out that %i seems to be... unfortunately the documentation of systemd doesn't really help)

So where are we at with this, I assume now that dashes are still an issue? https://github.com/marvel-nccr/ansible-role-aiida/pull/49#issue-509977388

chrisjsewell commented 3 years ago

This also goes part way to closing https://github.com/marvel-nccr/quantum-mobile/issues/126. Are these links to the v4 variants that gio mentions?

I will make a PR for https://github.com/marvel-nccr/ansible-role-quantum-espresso to change them there as well (plus update the repo). I guess its good to have them there as well, for standalone purposes (or could just remove them)? But at least set the default in quantum-mobile to quantum_espresso_pps: [] so that we don't duplicate the download